Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): hash the same environment as the tasks are run with #19487

Merged
merged 1 commit into from
Oct 7, 2023

Conversation

FrozenPandaz
Copy link
Collaborator

Current Behavior

The hasher's process environment variables are hashed for a task while the task might be run with a different environment

Expected Behavior

The hasher hashes a task with a given environment which is identical to the one where it is run.

Related Issue(s)

Fixes #19392

@vercel
Copy link

vercel bot commented Oct 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Oct 6, 2023 10:25pm

@FrozenPandaz FrozenPandaz merged commit dde9106 into nrwl:master Oct 7, 2023
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 13, 2023
@FrozenPandaz FrozenPandaz deleted the fix-env-hashing branch October 14, 2023 00:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dotenv file for each task and configuration must be read before determining whether a cache hit has occurred.
2 participants