fix(react): transpile only the config files then disable tsnode service #19387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coly010
requested review from
ndcunningham,
FrozenPandaz,
jaysoo and
leosvelperez
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 35ca91d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
Coly010
force-pushed
the
fix/module-federation-dev-servers
branch
2 times, most recently
from
df4b00c to
f5ca733
Compare
leosvelperez
approved these changes
Oct 2, 2023
Coly010
force-pushed
the
fix/module-federation-dev-servers
branch
from
f5ca733 to
49f0a5d
Compare
Coly010
force-pushed
the
fix/module-federation-dev-servers
branch
from
49f0a5d to
19aa7a1
Compare
Coly010
requested review from
a team,
vsavkin,
philipjfulcher and
bcabanes
as code owners
Coly010
force-pushed
the
fix/module-federation-dev-servers
branch
3 times, most recently
from
19e4d17 to
291c678
Compare
meeroslav
reviewed
Oct 3, 2023
meeroslav
reviewed
Oct 3, 2023
meeroslav
approved these changes
Oct 3, 2023
mandarini
approved these changes
Oct 3, 2023
Coly010
force-pushed
the
fix/module-federation-dev-servers
branch
from
291c678 to
fbe26eb
Compare
Coly010
force-pushed
the
fix/module-federation-dev-servers
branch
from
fbe26eb to
65fa142
Compare
ndcunningham
approved these changes
Oct 3, 2023
jaysoo
reviewed
Oct 3, 2023
packages/react/src/executors/module-federation-dev-server/module-federation-dev-server.impl.ts
Outdated
Show resolved
Hide resolved
FrozenPandaz
requested changes
Oct 3, 2023
graph/client-e2e/project.json
Outdated
| @@ -4,7 +4,17 @@ | |||
| "sourceRoot": "graph/client-e2e/src", | |||
| "projectType": "application", | |||
| "targets": { | |||
| "pre-e2e": { | |||
There was a problem hiding this comment.
This stuff is separate right? Can we sort this out outside of this PR?
Coly010
force-pushed
the
fix/module-federation-dev-servers
branch
from
caedb36 to
b9ef59c
Compare
Coly010
force-pushed
the
fix/module-federation-dev-servers
branch
from
b9ef59c to
bae6674
Compare
FrozenPandaz
requested changes
Oct 3, 2023
| @@ -3,6 +3,7 @@ import { join } from 'path'; | |||
| import { existsSync, readFileSync } from 'fs'; | |||
| import { logger } from '@nx/devkit'; | |||
| import { tsNodeRegister } from '@nx/js/src/utils/typescript/tsnode-register'; | |||
| import { registerTsProject } from 'nx/src/utils/register'; | |||
There was a problem hiding this comment.
This should come from @nx/js/src/internal
| @@ -1,5 +1,6 @@ | |||
| import { merge } from 'webpack-merge'; | |||
| import { tsNodeRegister } from '@nx/js/src/utils/typescript/tsnode-register'; | |||
| import { registerTsProject } from 'nx/src/utils/register'; | |||
There was a problem hiding this comment.
This should come from @nx/js/src/internal
FrozenPandaz
approved these changes
Oct 3, 2023
jaysoo
approved these changes
Oct 3, 2023
FrozenPandaz
pushed a commit
that referenced
this pull request
Oct 4, 2023
Co-authored-by: Jason Jean <[email protected]> (cherry picked from commit a11e8f1)
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Dev Remotes cause both a TS error with redeclared const in a block-scope and type-checking running out of memory.
Expected Behavior
Dev remotes with a TS Config should work without issue
Related Issue(s)
Fixes #