Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): generate permissions on github ci workflow #19357

Merged
merged 1 commit into from
Sep 28, 2023

Conversation

JamesHenry
Copy link
Collaborator

Current Behavior

Folks need to add permissions themselves to make runs on the main branch work correctly with nx-set-shas (used within the shared CI workflow).

Expected Behavior

Appropriate permissions are already generated by the generator

Related Issue(s)

Fixes #

@JamesHenry JamesHenry requested a review from a team as a code owner September 27, 2023 21:54
@vercel
Copy link

vercel bot commented Sep 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Sep 27, 2023 9:55pm

Copy link
Contributor

@meeroslav meeroslav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@JamesHenry JamesHenry merged commit 9448b68 into nrwl:master Sep 28, 2023
@JamesHenry JamesHenry deleted the github-ci-workflow-update branch September 28, 2023 00:54
@github-actions
Copy link

github-actions bot commented Oct 4, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants