fix(core): adjust how findMatchingProjects works when provided additive patterns after an exclusion to be more intuitive #19295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 7a2885d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution
✅ Successfully ran 5 targets
Sent with 💌 from NxCloud. |
FrozenPandaz
requested changes
Sep 22, 2023
AgentEnder
force-pushed
the
fix/find-matching-project-negation-addition
branch
from
78b5fbe to
b760669
Compare
AgentEnder
force-pushed
the
fix/find-matching-project-negation-addition
branch
from
b760669 to
a27eeca
Compare
AgentEnder
force-pushed
the
fix/find-matching-project-negation-addition
branch
2 times, most recently
from
a90e93d to
52ba219
Compare
…ve patterns after an exclusion to be more intuitive
AgentEnder
force-pushed
the
fix/find-matching-project-negation-addition
branch
from
52ba219 to
7a2885d
Compare
FrozenPandaz
approved these changes
Oct 3, 2023
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
A list of patterns such as
['*', '!packages/*', 'my-package']will not include'my-package'as a result. This behavior feels weird though, as intuitively the patterns are parsed as:However, mechanically, we currently handle exclusions at the very end of processing patterns. This means we parse it as:
Expected Behavior
Pattern parsing is intuitive.
Related Issue(s)
Fixes #19210