fix(core): support prettier v3 when run nx format #19207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit dabc9e5. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
abel1105
force-pushed
the
fix/prettier-v3-format
branch
3 times, most recently
from
8f68179 to
87ec362
Compare
abel1105
force-pushed
the
fix/prettier-v3-format
branch
2 times, most recently
from
1680791 to
1895f4c
Compare
AgentEnder
approved these changes
Sep 27, 2023
AgentEnder
force-pushed
the
fix/prettier-v3-format
branch
from
1895f4c to
83e31f4
Compare
abel1105
force-pushed
the
fix/prettier-v3-format
branch
from
83e31f4 to
64ca6f5
Compare
Closed
4 tasks
After prettier upgrade to v3, the getSupportInfo will return promise Closes nrwl#18992
abel1105
force-pushed
the
fix/prettier-v3-format
branch
from
64ca6f5 to
dabc9e5
Compare
AgentEnder
approved these changes
Oct 16, 2023
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After prettier upgrade to v3, the
prettier.getSupportInfowill return promiseref: Prettier doc
Closes #18992
Current Behavior
When running
nx format:checkwill always fallback to-files=.Expected Behavior
It should only run prettier on those changed files.
Related Issue(s)
Fixes #18992