feat(angular): switch default to typescript configuration for module federation #18998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 9072762. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
Coly010
force-pushed
the
mf/use-ts-configuration
branch
from
9a493ee to
10e5371
Compare
Coly010
force-pushed
the
mf/use-ts-configuration
branch
from
10e5371 to
33ce81d
Compare
Coly010
force-pushed
the
mf/use-ts-configuration
branch
from
33ce81d to
35cb8df
Compare
Coly010
force-pushed
the
mf/use-ts-configuration
branch
2 times, most recently
from
38f4172 to
a3090ec
Compare
Coly010
force-pushed
the
mf/use-ts-configuration
branch
from
a3090ec to
b53ffbb
Compare
Coly010
force-pushed
the
mf/use-ts-configuration
branch
from
b53ffbb to
d7d5931
Compare
Coly010
force-pushed
the
mf/use-ts-configuration
branch
from
d7d5931 to
d6f6604
Compare
Coly010
force-pushed
the
mf/use-ts-configuration
branch
from
d6f6604 to
4ec5ebe
Compare
Coly010
force-pushed
the
mf/use-ts-configuration
branch
from
4ec5ebe to
f77709a
Compare
jaysoo
reviewed
Sep 21, 2023
jaysoo
reviewed
Sep 21, 2023
packages/angular/src/builders/module-federation-dev-server/module-federation-dev-server.impl.ts
Outdated
Show resolved
Hide resolved
meeroslav
reviewed
Oct 3, 2023
Coly010
force-pushed
the
mf/use-ts-configuration
branch
from
f77709a to
1e5fe65
Compare
Coly010
force-pushed
the
mf/use-ts-configuration
branch
from
1e5fe65 to
fd25d38
Compare
Coly010
force-pushed
the
mf/use-ts-configuration
branch
from
fd25d38 to
a51ba3f
Compare
Coly010
force-pushed
the
mf/use-ts-configuration
branch
from
a51ba3f to
efe5c43
Compare
Coly010
force-pushed
the
mf/use-ts-configuration
branch
from
efe5c43 to
9cfe3c2
Compare
meeroslav
approved these changes
Oct 5, 2023
mandarini
approved these changes
Oct 5, 2023
Coly010
force-pushed
the
mf/use-ts-configuration
branch
from
9cfe3c2 to
202362d
Compare
packages/angular/src/generators/host/files/ts/src/main.server.ts__tmpl__
Outdated
Show resolved
Hide resolved
packages/angular/src/generators/remote/files/base-ts/src/main.server.ts__tmpl__
Outdated
Show resolved
Hide resolved
Coly010
force-pushed
the
mf/use-ts-configuration
branch
from
202362d to
9072762
Compare
leosvelperez
approved these changes
Oct 10, 2023
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
We currently generate JS config files for webpack and module federation with the host, remote and setup-mf generators
Expected Behavior
We should generate TS config files
Related Issue(s)
Fixes #