Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(linter): fix dep-checks projPackageJsonDeps caching for IDE #18935

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

meeroslav
Copy link
Contributor

Current Behavior

The projPackageJsonDeps is cached per runtime, which causes false failures on IDE when switching between projects.

Expected Behavior

The projPackageJsonDeps should not be cached for IDE runs.

Related Issue(s)

Fixes #

@meeroslav meeroslav added the scope: linter Issues related to Eslint support in Nx label Aug 31, 2023
@meeroslav meeroslav self-assigned this Aug 31, 2023
@meeroslav meeroslav requested a review from a team as a code owner August 31, 2023 12:44
@meeroslav meeroslav requested a review from FrozenPandaz August 31, 2023 12:44
@vercel
Copy link

vercel bot commented Aug 31, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Sep 5, 2023 11:09am

@meeroslav meeroslav requested a review from MaxKless August 31, 2023 12:45
@meeroslav meeroslav force-pushed the fix-linter-dep-checks-cache branch from f044253 to d716369 Compare August 31, 2023 12:48
@meeroslav meeroslav force-pushed the fix-linter-dep-checks-cache branch from d716369 to a097b95 Compare September 1, 2023 11:53
@meeroslav meeroslav requested a review from a team as a code owner September 1, 2023 15:44
@meeroslav meeroslav requested a review from mandarini September 1, 2023 15:44
@meeroslav meeroslav force-pushed the fix-linter-dep-checks-cache branch from 8bf1d57 to 6930985 Compare September 4, 2023 12:56
@meeroslav meeroslav force-pushed the fix-linter-dep-checks-cache branch from 6930985 to 0d12270 Compare September 5, 2023 11:08
@meeroslav meeroslav merged commit 2bc7031 into nrwl:master Sep 6, 2023
@meeroslav meeroslav deleted the fix-linter-dep-checks-cache branch September 6, 2023 08:19
FrozenPandaz pushed a commit that referenced this pull request Sep 7, 2023
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
scope: linter Issues related to Eslint support in Nx
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants