Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): use the correct output path for mf ssr #18849 #18906

Merged
merged 1 commit into from
Aug 30, 2023

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented Aug 30, 2023

Current Behavior

We hardcode the path to the built bundles when we generate an SSR setup for MF

Expected Behavior

Use the correct path from the project.json for the bundle paths

Related Issue(s)

Fixes #18849

@Coly010 Coly010 requested a review from a team as a code owner August 30, 2023 11:17
@Coly010 Coly010 requested a review from jaysoo August 30, 2023 11:17
@Coly010 Coly010 self-assigned this Aug 30, 2023
@vercel
Copy link

vercel bot commented Aug 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Aug 30, 2023 11:19am

@Coly010 Coly010 merged commit 5a06343 into nrwl:master Aug 30, 2023
3 checks passed
@Coly010 Coly010 deleted the angular/mf-hardcoded-paths branch August 30, 2023 11:53
@github-actions
Copy link

github-actions bot commented Sep 5, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename apps to packages directory in MF + SSR case
2 participants