Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): mark esbuild as optional peer dep #18526 #18771

Merged
merged 1 commit into from
Aug 22, 2023

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented Aug 22, 2023

Current Behavior

esbuild package is not considered an optional peer dependency

Expected Behavior

esbuild package should be considered an optional peer dependency

Related Issue(s)

Fixes #18526

@Coly010 Coly010 requested a review from a team as a code owner August 22, 2023 14:05
@Coly010 Coly010 self-assigned this Aug 22, 2023
@vercel
Copy link

vercel bot commented Aug 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 22, 2023 2:15pm

@Coly010 Coly010 enabled auto-merge (squash) August 22, 2023 14:06
@Coly010 Coly010 merged commit 1440f5c into nrwl:master Aug 22, 2023
3 checks passed
FrozenPandaz pushed a commit that referenced this pull request Aug 23, 2023
@Coly010 Coly010 deleted the angular/optional-esbuild branch August 23, 2023 11:14
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

esbuild should not be required peerDependency in @nx/angular
2 participants