-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(misc): format must exclude ignored patterns #18670
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`nx format` commands will now correctly ignore patterns defined in `.gitignore` or `.nxignore`
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
pongells
changed the title
fix(misc): format must exclude ignored patterns (#18568)
fix(misc): format must exclude ignored patterns
Aug 17, 2023
meeroslav
approved these changes
Aug 17, 2023
AgentEnder
approved these changes
Aug 21, 2023
@Cammisuli is there something missing? |
FrozenPandaz
pushed a commit
that referenced
this pull request
Aug 23, 2023
Co-authored-by: Stefano Pongelli <[email protected]> (cherry picked from commit c479a54)
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nx format
commands will now correctly ignorepatterns defined in
.gitignore
or.nxignore
Current Behavior
The
nx format
commands (write, check) do not take into account ignored patterns.Expected Behavior
The
nx format
commands (write, check) should not parse ignored patterns.Related Issue(s)
#18568
Fixes #18568