Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react): fix createGlobPAtternsForDependencies path #18546

Merged
merged 1 commit into from
Sep 6, 2023
Merged

fix(react): fix createGlobPAtternsForDependencies path #18546

merged 1 commit into from
Sep 6, 2023

Conversation

nadavshatz
Copy link
Contributor

Added missing * where was needed for libraries.

Current Behavior

patterns for tailwind content are missing *

Expected Behavior

patterns to fit all files as shown here https://github.com/nrwl/nx/blob/master/packages/react/src/generators/setup-tailwind/files/tailwind.config.js__tmpl__#L9

@nadavshatz nadavshatz requested a review from a team as a code owner August 9, 2023 12:57
@vercel
Copy link

vercel bot commented Aug 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 15, 2023 8:38am

Added missing * where was needed for libraries.
@nadavshatz
Copy link
Contributor Author

Can we get this merged please ?

@nadavshatz
Copy link
Contributor Author

@xiongemi something blocking this from merging? 🙏🏼

@ndcunningham ndcunningham merged commit ac85a16 into nrwl:master Sep 6, 2023
3 checks passed
FrozenPandaz pushed a commit that referenced this pull request Sep 7, 2023
@nadavshatz nadavshatz deleted the fix/react-tailwind branch September 11, 2023 10:52
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants