fix(react): remove hard-coded typings inside tsconfig and add them to the app

[ndcunningham]

Current Behavior

When you create a react app inside tsconfig.app.json and tsconfig.spec.json there are hardcoded references to typings inside node_modules.

If you use Yarn PnP these hardcoded references would fail since node_modules do not exist.

Expected Behavior

This PR removes the references from tsconfig and adds them directly to the app.
That way there would be no need to have hardcoded references and they would be automatically picked up during bundling without the need to anything additional.

Related Issue(s)

Fixes #

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
nx-dev	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 4, 2023 7:16pm

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 5403355. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 7 targets

• linux nx affected --target=e2e --base=543e9e30c5d1661d82a83b0563dfd2d809fe5991 --head=54033550939cc6398a387741e870e76367f25236 --parallel=1
• linux nx affected --target=test --base=543e9e30c5d1661d82a83b0563dfd2d809fe5991 --head=54033550939cc6398a387741e870e76367f25236 --parallel=1
• linux nx affected --target=build --base=543e9e30c5d1661d82a83b0563dfd2d809fe5991 --head=54033550939cc6398a387741e870e76367f25236 --parallel=3
• linux nx run-many -t check-imports check-commit check-lock-files check-codeowners documentation --parallel=1 --no-dte
• linux nx affected --target=lint --base=543e9e30c5d1661d82a83b0563dfd2d809fe5991 --head=54033550939cc6398a387741e870e76367f25236 --parallel=3
• nx-cloud record -- nx format:check --base=543e9e30c5d1661d82a83b0563dfd2d809fe5991 --head=54033550939cc6398a387741e870e76367f25236
• linux nx documentation --no-dte

---

Sent with 💌 from NxCloud.

[meeroslav]

Looks good to me.

There is one broken nextjs test that needs to be fixed and I left one comment.

[ndcunningham]

Closing in favor of: #18501

[github-actions]

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.