-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(bundling): fallback to manual file resolution if tsconfig-paths fails #18477
fix(bundling): fallback to manual file resolution if tsconfig-paths fails #18477
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Community slack convo for reference: https://nrwlcommunity.slack.com/archives/CMFKWPU6Q/p1691087332889809 and example repo where this fix is needed |
I think maybe my issue is related to this (?) #18492 |
32422c7
to
aa4c584
Compare
aa4c584
to
57279b0
Compare
57279b0
to
763b682
Compare
763b682
to
fa4ebcb
Compare
fa4ebcb
to
bea7b4b
Compare
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Current Behavior
nxViteTsPaths plugin assumes a file can be resolved via package.json fields,
when there isn't always a package.json to resolve from in a mapped tsconfig path.
causing vite to not be able to understand some cjs deps see #18459
Expected Behavior
able to resolve files from paths that don't contain package.json
also includes options to plugin for debugging, selecting package.json fields, and extenions for file resolving.
Related Issue(s)
Fixes #18459