Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(esbuild): don't overwrite plugins in esbuildOptions #18461

Merged
merged 1 commit into from
Aug 4, 2023

Conversation

rkorrelboom
Copy link
Contributor

Current Behavior

plugins defined in esbuild.config.js are overwritten

Expected Behavior

plugins defined in esbuild.config.js are not overwritten

Related Issue(s)

Fixes #

@rkorrelboom rkorrelboom requested a review from a team as a code owner August 3, 2023 10:09
@rkorrelboom rkorrelboom requested a review from mandarini August 3, 2023 10:09
@vercel
Copy link

vercel bot commented Aug 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 4, 2023 8:37am

Copy link
Member

@mandarini mandarini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks this change makes sense!

@mandarini mandarini self-assigned this Aug 3, 2023
@mandarini
Copy link
Member

Can you please rebase with latest and repush, there was some sort of issue with the pipelines!

@mandarini
Copy link
Member

Hmm can you please run nx format? And see what else may be failing? @rkorrelboom

@mandarini
Copy link
Member

@rkorrelboom I'll take a look today at what's going on here

@rkorrelboom
Copy link
Contributor Author

Thanks @mandarini , I wasn't able to figure it out by looking at the logs

@mandarini mandarini force-pushed the fix/load-custom-esbuild-plugins branch from fd9f4ae to 73bbf00 Compare August 4, 2023 08:34
@mandarini mandarini merged commit 14fab26 into nrwl:master Aug 4, 2023
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants