feat(testing): Vite 5 compatibility

[benmccann]

Current Behavior

Currently doing a require of vite

Expected Behavior

Do an import of vite to use the ESM version as the CJS version is likely to be dropped or cause a warning in the next release

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
nx-dev	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 8, 2023 6:05pm

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 8b62904. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

⌛ The following targets are in progress

• linux nx affected --target=build --base=d7d3ebc3a8a57a7a8e838f8900e990c9b73f5d13 --head=8b629048a9ba13264ffe15acfaad1838bb8665f8 --parallel=3
• linux nx affected --target=test --base=d7d3ebc3a8a57a7a8e838f8900e990c9b73f5d13 --head=8b629048a9ba13264ffe15acfaad1838bb8665f8 --parallel=1

🟥 Failed Commands
linux nx run-many -t check-imports check-commit check-lock-files check-codeowners documentation --parallel=1 --no-dte

✅ Successfully ran 3 targets

• linux nx affected --target=lint --base=d7d3ebc3a8a57a7a8e838f8900e990c9b73f5d13 --head=8b629048a9ba13264ffe15acfaad1838bb8665f8 --parallel=3
• nx-cloud record -- nx format:check --base=d7d3ebc3a8a57a7a8e838f8900e990c9b73f5d13 --head=8b629048a9ba13264ffe15acfaad1838bb8665f8
• linux nx documentation --no-dte

---

Sent with 💌 from NxCloud.

[benmccann]

@FrozenPandaz @barbados-clemens @mandarini would you be able to give this simple 1-liner a quick look? Thanks!

[mandarini]

@benmccann thanks for the PR! I approved, but still needs approval from a code owner!

[barbados-clemens]

Looks like a format error. you can run
nx format and it'll clear that up for you.

[barbados-clemens]

Hi @benmccann our pipeline validates commit message so they meet a specific format, which is what is current failing on the PR.

https://staging.nx.app/runs/m96AKc6LUX

You'll want to rename the commits to match the described format.

[benmccann]

Yeah, I don't know how to do that since some of the commits are further back in history and commits from master have been merged in the middle. I'll just close this and open a clean PR.

[benmccann]

New PR here: #18535

[github-actions]

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.