Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): update magic-string dependency #18389

Merged
merged 1 commit into from
Jul 31, 2023

Conversation

leosvelperez
Copy link
Member

@leosvelperez leosvelperez commented Jul 31, 2023

Current Behavior

@nx/angular depends on [email protected] which depends on the deprecated sourcemap-codec package.

Expected Behavior

@nx/angular should depend on a newer version of magic-string that no longer depends on the deprecated sourcemap-codec package.

Related Issue(s)

Fixes #

@leosvelperez leosvelperez added the scope: angular Issues related to Angular support in Nx label Jul 31, 2023
@leosvelperez leosvelperez self-assigned this Jul 31, 2023
@vercel
Copy link

vercel bot commented Jul 31, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 31, 2023 10:37am

@leosvelperez leosvelperez marked this pull request as ready for review July 31, 2023 11:36
@leosvelperez leosvelperez requested review from a team as code owners July 31, 2023 11:36
@FrozenPandaz FrozenPandaz merged commit 3359249 into nrwl:master Jul 31, 2023
@leosvelperez leosvelperez deleted the angular/update-magic-string branch July 31, 2023 16:22
@github-actions
Copy link

github-actions bot commented Aug 6, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
scope: angular Issues related to Angular support in Nx
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants