feat(bundling): generate and bundle type definitions in rollup executor #18318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jaysoo
force-pushed
the
bundling/rollup-generate-types
branch
from
d629bd4 to
32a64e3
Compare
jaysoo
approved these changes
Jul 27, 2023
jaysoo
force-pushed
the
bundling/rollup-generate-types
branch
from
32a64e3 to
f4ce65e
Compare
jaysoo
force-pushed
the
bundling/rollup-generate-types
branch
from
f4ce65e to
d75839e
Compare
leosvelperez
force-pushed
the
bundling/rollup-generate-types
branch
from
d75839e to
6de4c81
Compare
leosvelperez
added
the
PR status: do not merge
leosvelperez
removed
the
PR status: do not merge
|
Closing in favor of not-bundling but matching by filename: #18342 We can revisit d.ts bundle later once we have something working for esbuild. |
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
The
rollupexecutor doesn't generate type definitions forswc. The type definitions generated when using thetscandbabelcompilers are not bundled.Expected Behavior
The
rollupexecutor should generate and bundle type definitions for all compilers.Related Issue(s)
Fixes #