fix(js): generate ts standalone project with better import path #18197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jaysoo
force-pushed
the
fix/ts-standalone-import-path
branch
from
da2c0ea to
0e0b330
Compare
ndcunningham
approved these changes
Jul 20, 2023
jaysoo
force-pushed
the
fix/ts-standalone-import-path
branch
3 times, most recently
from
d712335 to
326f5d4
Compare
jaysoo
force-pushed
the
fix/ts-standalone-import-path
branch
from
326f5d4 to
7489074
Compare
jaysoo
commented
Jul 24, 2023
| @@ -79,7 +79,7 @@ describe('Storybook generators and executors for standalone workspaces - using R | |||
| writeFileSync( | |||
| tmpProjPath(`src/app/test-button.tsx`), | |||
| ` | |||
| import { MyLib } from '@${appName}/my-lib'; | |||
| import { MyLib } from 'my-lib'; | |||
There was a problem hiding this comment.
Since the standalone app isn't scoped by default now (just the app's name in package.json), the library does not default to a scope either.
AgentEnder
approved these changes
Jul 24, 2023
FrozenPandaz
approved these changes
Jul 25, 2023
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue with standalone TS projects (
npx create-nx-workspace --preset=ts-standalone) where thenameinpackage.jsonis invalid.Current Behavior
The name is something like
@acme/.Expected Behavior
The name should be the name of the folder (e.g.
acme).Related Issue(s)
Fixes #