-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(vite): add v8 coverage support to vitest generator #18114
feat(vite): add v8 coverage support to vitest generator #18114
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
I've been unable to verify this is working as expected as I received errors when trying to create a new workspace using the locally published package (errors seemed unrelated to my changes). Could someone help me test/verify that it's working as expected? |
6769648
to
cc454b7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple changes and you'll want to rebase with master.
5954989
to
833168f
Compare
I think I've addressed the comments correctly, and rebased. Let me know if any further changes are required 👍 |
833168f
to
05184d4
Compare
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Current Behavior
Vitest generator has no option for v8 coverage and defaults to c8
Expected Behavior
Vitest generator should allow (and default to) v8 coverage
Related Issue(s)
Fixes #17886