Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vite): add v8 coverage support to vitest generator #18114

Merged

Conversation

mpgregson
Copy link
Contributor

Current Behavior

Vitest generator has no option for v8 coverage and defaults to c8

Expected Behavior

Vitest generator should allow (and default to) v8 coverage

Related Issue(s)

Fixes #17886

@mpgregson mpgregson requested a review from a team as a code owner July 14, 2023 10:37
@mpgregson mpgregson requested a review from jaysoo July 14, 2023 10:37
@vercel
Copy link

vercel bot commented Jul 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 27, 2023 6:41am

@mpgregson
Copy link
Contributor Author

I've been unable to verify this is working as expected as I received errors when trying to create a new workspace using the locally published package (errors seemed unrelated to my changes).

Could someone help me test/verify that it's working as expected?

@mpgregson mpgregson force-pushed the feat/vitest-generator-v8-coverage branch from 6769648 to cc454b7 Compare July 14, 2023 10:46
@mpgregson mpgregson requested a review from a team as a code owner July 14, 2023 10:46
@mpgregson mpgregson requested a review from meeroslav July 14, 2023 10:46
Copy link
Contributor

@barbados-clemens barbados-clemens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple changes and you'll want to rebase with master.

packages/vite/migrations.json Outdated Show resolved Hide resolved
packages/vite/src/utils/versions.ts Outdated Show resolved Hide resolved
@mpgregson
Copy link
Contributor Author

Just a couple changes and you'll want to rebase with master.

I think I've addressed the comments correctly, and rebased. Let me know if any further changes are required 👍

@github-actions
Copy link

github-actions bot commented Aug 2, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add @vitest/coverage-v8 to vitest generator
4 participants