docs(misc): replace mention of old @nx/node:package with @nx/js:tsc #18102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit b464ac9. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
leosvelperez
force-pushed
the
docs/wrong-executor
branch
from
b20e86a to
b464ac9
Compare
isaacplmann
approved these changes
Jul 14, 2023
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated doc: https://nx-dev-git-fork-leosvelperez-docs-wrong-executor-nrwl.vercel.app/recipes/other/include-assets-in-build#including-assets-in-your-build
Current Behavior
Docs about including assets in builds mention the non-existent
@nx/node:packagein the example project config.Expected Behavior
Docs should not mention the non-existent
@nx/node:packagein the example project config. They should mention a valid executor, like@nx/js:tsc.Related Issue(s)
Fixes #18088