Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(js): add docs about @nx/js:tsc batch execution #18071

Merged

Conversation

leosvelperez
Copy link
Member

@leosvelperez leosvelperez commented Jul 11, 2023

Docs changed:

Current Behavior

There's no mention in the docs about the new @nx/js:tsc batch implementation.

Expected Behavior

The @nx/js:tsc batch implementation should be mentioned in the incremental builds docs and in the @nx/js:tsc executor examples.

Related Issue(s)

Fixes #

@leosvelperez leosvelperez self-assigned this Jul 11, 2023
@vercel
Copy link

vercel bot commented Jul 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 12, 2023 7:51am

@nx-cloud
Copy link

nx-cloud bot commented Jul 11, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 16f6d5a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@leosvelperez leosvelperez marked this pull request as ready for review July 11, 2023 14:57
@leosvelperez leosvelperez requested review from a team as code owners July 11, 2023 14:58
Copy link
Collaborator

@isaacplmann isaacplmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine for now. We should make a follow up PR to rewrite the incremental builds concept guide to stay more on the conceptual level and then we could link to 3 separate recipes:

  1. Set up incremental builds with webpack (React)
  2. Set up incremental builds with Angular
  3. Set up incremental builds with typescript

Recipe 1 could be created from parts of the concept guide.
Recipe 2 is already written.
Your new section would go in recipe 3.

@leosvelperez leosvelperez merged commit 4f9f04f into nrwl:master Jul 14, 2023
@leosvelperez leosvelperez deleted the docs/incremental-builds-js-batch-mode branch July 14, 2023 07:41
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants