fix(core): use concat in buildAllWorkspaceFiles to avoid Maximum call stack size exceeded

[chentsulin]

Use .concat instead of .push(...arr) to avoid Maximum call stack size exceeded.

Current Behavior

Got this error in an large monorepo:

/home/********/project/node_modules/.pnpm/[email protected]/node_modules/nx/src/project-graph/utils/retrieve-workspace-files.js:68
    fileData.push(...globalFiles);
             ^

RangeError: Maximum call stack size exceeded
    at buildAllWorkspaceFiles (/home/********/project/node_modules/.pnpm/[email protected]/node_modules/nx/src/project-graph/utils/retrieve-workspace-files.js:68:14)
    at /home/********/project/node_modules/.pnpm/[email protected]/node_modules/nx/src/project-graph/utils/retrieve-workspace-files.js:43:32
    at Generator.next (<anonymous>)
    at fulfilled (/home/********/project/node_modules/.pnpm/[email protected]/node_modules/tslib/tslib.js:166:62)

Expected Behavior

Do not throw RangeError: Maximum call stack size exceeded

Related Issue(s)

Fixes #

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
nx-dev	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 11, 2023 5:17pm

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit b44823c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 1 target

• nx affected -t e2e-macos --parallel=1 --base=95a2256a34609e4eecc2a29a802cbf8d292eda47 --head=b44823cd603c31beaccc780cb526662d73b38b99

---

Sent with 💌 from NxCloud.

[Cammisuli]

Thanks for the PR! I seen someone complain about this before, but they didn't give me much info, and the problem was fixed for them when they used a different version of Node.

Is the Nx workspace that gave you this error open source or available for me to use as a benchmark?

[chentsulin]

@Cammisuli It's a private repo, so I can't share with you. Sorry for that.

[Cammisuli]

@chentsulin can I get some details on the workspace? How many projects do you have, and how many global files were there as well?

[chentsulin]

@Cammisuli AFAICT, we have more than 100 packages and 30 Next.js websites.

[github-actions]

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.