feat(testing): renamed cypress-e2e-configuration to configuration to maintain consistency between plugins #17998
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jaysoo
force-pushed
the
feat/cypress-consistency-naming
branch
from
70d9b8c to
e180a4a
Compare
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 0695f7d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
jaysoo
force-pushed
the
feat/cypress-consistency-naming
branch
from
e180a4a to
c369af4
Compare
jaysoo
force-pushed
the
feat/cypress-consistency-naming
branch
from
c369af4 to
9bdf753
Compare
| "cypress-e2e-configuration": { | ||
| "aliases": ["e2e", "e2e-config"], | ||
| "factory": "./src/generators/cypress-e2e-configuration/cypress-e2e-configuration#compat", | ||
| "schema": "./src/generators/cypress-e2e-configuration/schema.json", | ||
| "configuration": { | ||
| "aliases": ["cypress-e2e-configuration", "e2e", "e2e-config"], | ||
| "factory": "./src/generators/configuration/configuration#compat", | ||
| "schema": "./src/generators/configuration/schema.json", | ||
| "description": "Add a Cypress E2E Configuration to an existing project." | ||
| }, | ||
| "cypress-component-configuration": { | ||
| "factory": "./src/generators/cypress-component-configuration/cypress-component-configuration#cypressComponentConfiguration", | ||
| "schema": "./src/generators/cypress-component-configuration/schema.json", | ||
| "component-configuration": { | ||
| "aliases": ["cypress-component-configuration"], | ||
| "factory": "./src/generators/component-configuration/component-configuration#compat", |
There was a problem hiding this comment.
I think @nx/cypress:cypress-e2e-configuration should be @nx/cypress:e2e-configuration instead of just configuration since the generator assumes e2e setup which might catch people off?
but also just hate the long names to begin with so kind of split. but figured I'd bring it up.
There was a problem hiding this comment.
I think keeping it as configuration is fine, an matches the other configuration generators. Component tests is a special case of Cypress I think.
jaysoo
force-pushed
the
feat/cypress-consistency-naming
branch
from
9bdf753 to
7f097c0
Compare
…aintain consistency between plugins Also rename cypress-component-configuration to component-configuration
jaysoo
force-pushed
the
feat/cypress-consistency-naming
branch
from
7f097c0 to
0695f7d
Compare
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This PR renames
@nx/cypress:cypress-e2e-configurationto@nx/cypress:configurationto maintain consistency between plugins (e.g. Vite is already@nx/vite:configuration).Also renames
@nx/cypress:cypress-component-configurationto@nx/cypress:component-configurationsince "cypress" is implied by the package name.What's done:
Current Behavior
Expected Behavior
Related Issue(s)
Fixes #