Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(angular): add esbuild incremental build builder #17991

Merged

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented Jul 6, 2023

Current Behavior

We do not have a way to support incremental builds with EsBuild for Angular

Expected Behavior

Support Incremental Builds with EsBuild for Angular

  • Add's a new executor that handles the incremental build support
  • Add's a util to allow us to call Angular builder functions from an executor

Related Issue(s)

Fixes #

@vercel
Copy link

vercel bot commented Jul 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 17, 2023 3:10pm

@Coly010 Coly010 self-assigned this Jul 6, 2023
@Coly010 Coly010 force-pushed the angular/esbuild-incremental-build-executor branch 2 times, most recently from 7af1ea0 to b12f49f Compare July 6, 2023 12:54
@nx-cloud
Copy link

nx-cloud bot commented Jul 6, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit fe9b14b. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

packages/nx/src/adapter/ngcli-adapter.ts Outdated Show resolved Hide resolved
packages/nx/src/adapter/ngcli-adapter.ts Outdated Show resolved Hide resolved
packages/nx/src/adapter/ngcli-adapter.ts Outdated Show resolved Hide resolved
packages/nx/src/adapter/ngcli-adapter.ts Outdated Show resolved Hide resolved
packages/nx/src/adapter/ngcli-adapter.ts Outdated Show resolved Hide resolved
@Coly010 Coly010 force-pushed the angular/esbuild-incremental-build-executor branch from 8e52d7c to 956955d Compare July 11, 2023 09:27
@Coly010 Coly010 requested a review from leosvelperez July 11, 2023 09:27
@Coly010 Coly010 force-pushed the angular/esbuild-incremental-build-executor branch from 956955d to e1bd229 Compare July 11, 2023 11:02
e2e/angular-core/src/projects.test.ts Outdated Show resolved Hide resolved
packages/nx/src/adapter/ngcli-adapter.ts Outdated Show resolved Hide resolved
packages/nx/src/adapter/ngcli-adapter.ts Outdated Show resolved Hide resolved
packages/nx/src/adapter/ngcli-adapter.ts Outdated Show resolved Hide resolved
@Coly010 Coly010 force-pushed the angular/esbuild-incremental-build-executor branch from e1bd229 to e31f47c Compare July 12, 2023 08:57
@Coly010 Coly010 force-pushed the angular/esbuild-incremental-build-executor branch from e31f47c to 0e75355 Compare July 12, 2023 09:02
@Coly010 Coly010 force-pushed the angular/esbuild-incremental-build-executor branch from 0e75355 to 6a7099e Compare July 12, 2023 12:26
@Coly010 Coly010 force-pushed the angular/esbuild-incremental-build-executor branch from 6a7099e to 757ebd3 Compare July 12, 2023 13:51
@Coly010 Coly010 requested a review from leosvelperez July 12, 2023 14:24
packages/nx/src/adapter/ngcli-adapter.ts Outdated Show resolved Hide resolved
packages/nx/src/adapter/ngcli-adapter.ts Outdated Show resolved Hide resolved
packages/nx/src/adapter/ngcli-adapter.ts Outdated Show resolved Hide resolved
@Coly010 Coly010 force-pushed the angular/esbuild-incremental-build-executor branch from 757ebd3 to 1354f50 Compare July 12, 2023 14:39
@Coly010 Coly010 requested a review from leosvelperez July 12, 2023 14:39
@Coly010 Coly010 force-pushed the angular/esbuild-incremental-build-executor branch from 1354f50 to fe9b14b Compare July 17, 2023 15:07
@Coly010 Coly010 merged commit 3fefbaf into nrwl:master Jul 18, 2023
@Coly010 Coly010 deleted the angular/esbuild-incremental-build-executor branch July 18, 2023 14:36
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants