Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(linter): add documentation on dependency-checks rule #17962

Merged
merged 3 commits into from
Jul 7, 2023
Merged

docs(linter): add documentation on dependency-checks rule #17962

merged 3 commits into from
Jul 7, 2023

Conversation

meeroslav
Copy link
Contributor

@meeroslav meeroslav commented Jul 5, 2023 •
edited
Loading

@meeroslav meeroslav added type: docs scope: linter Issues related to Eslint support in Nx labels Jul 5, 2023
@meeroslav meeroslav self-assigned this Jul 5, 2023
@meeroslav meeroslav requested review from FrozenPandaz, jaysoo, AgentEnder and a team as code owners July 5, 2023 12:06
@meeroslav meeroslav requested a review from ZackDeRose July 5, 2023 12:06
@vercel
Copy link

vercel bot commented Jul 5, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 6, 2023 8:34pm

@nx-cloud
Copy link

nx-cloud bot commented Jul 5, 2023 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 03f71e5. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@meeroslav meeroslav enabled auto-merge (squash) July 5, 2023 12:52
isaacplmann
isaacplmann requested changes Jul 5, 2023
View reviewed changes
docs/shared/packages/linter/eslint-plugin.md Outdated Show resolved Hide resolved
docs/shared/packages/linter/eslint-plugin.md Outdated Show resolved Hide resolved
docs/shared/packages/linter/eslint-plugin.md Outdated Show resolved Hide resolved
docs/shared/packages/linter/dependency-checks.md Outdated Show resolved Hide resolved
docs/shared/packages/linter/dependency-checks.md Show resolved Hide resolved
docs/shared/packages/linter/dependency-checks.md Outdated Show resolved Hide resolved
docs/shared/packages/linter/dependency-checks.md Outdated Show resolved Hide resolved
docs/shared/packages/linter/dependency-checks.md Outdated Show resolved Hide resolved
@meeroslav meeroslav requested a review from isaacplmann July 6, 2023 09:21
@leosvelperez leosvelperez mentioned this pull request Jul 6, 2023
Merged
isaacplmann
isaacplmann requested changes Jul 6, 2023
View reviewed changes
Copy link
Collaborator

@isaacplmann isaacplmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small change. Looks good otherwise.

docs/shared/packages/linter/dependency-checks.md Outdated Show resolved Hide resolved
@meeroslav meeroslav force-pushed the docs-add-linter-rule-docs branch from 8278c7e to 03f71e5 Compare July 6, 2023 20:31
@meeroslav meeroslav requested a review from isaacplmann July 6, 2023 20:31
@meeroslav meeroslav merged commit 5af5e6c into nrwl:master Jul 7, 2023
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@isaacplmann isaacplmann isaacplmann approved these changes

@jaysoo jaysoo jaysoo approved these changes

@FrozenPandaz FrozenPandaz Awaiting requested review from FrozenPandaz FrozenPandaz is a code owner

@AgentEnder AgentEnder Awaiting requested review from AgentEnder AgentEnder is a code owner

@ZackDeRose ZackDeRose Awaiting requested review from ZackDeRose ZackDeRose is a code owner automatically assigned from nrwl/nx-docs-reviewers

Assignees

@meeroslav meeroslav

Labels
scope: linter Issues related to Eslint support in Nx type: docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@meeroslav @jaysoo @isaacplmann