Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nextjs): updated 0.0.0.0 as default hostname (#17902) #17903

Closed

Conversation

rahulretnan
Copy link

Current Behavior

The nx workspace opensource project has an issue with serving the nx next application locally. The default hostname used is "localhost."

Expected Behavior

After the changes in this PR, the nx workspace should be able to serve the nx next application locally without any issues. The default hostname will be changed to "0.0.0.0" to ensure proper local serving.

Fixes #17902

@rahulretnan rahulretnan requested review from a team as code owners July 1, 2023 12:09
@rahulretnan rahulretnan requested review from jaysoo and bcabanes July 1, 2023 12:09
@vercel
Copy link

vercel bot commented Jul 1, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 1, 2023 0:12am

@nx-cloud
Copy link

nx-cloud bot commented Jul 1, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 59408e7. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@michaelangeloio
Copy link

See this comment first: #17902 (comment)

@ndcunningham
Copy link
Contributor

Already addressed with: #17931

If you want to pass 0.0.0.0 you can use the --hostname flag

@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants