Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): fix workspace validation for implicitDependencies that are… #17825

Merged
merged 1 commit into from
Jun 28, 2023
Merged

fix(core): fix workspace validation for implicitDependencies that are… #17825

merged 1 commit into from
Jun 28, 2023

Conversation

FrozenPandaz
Copy link
Collaborator

… not arrays

Current Behavior

When a project is configured to use '*' or anything that is not an array as implicitDependencies, a cryptic error is thrown:

>  NX   desiredImplicitDeps.filter is not a function

Expected Behavior

When a project is configured to use '*' or anything that is not an array as implicitDependencies, a clear error is thrown:

Configuration Error
  The following implicitDependencies should be an array of strings:
    lib1.implicitDependencies: "*"

Related Issue(s)

Fixes #17355

@FrozenPandaz FrozenPandaz requested a review from a team as a code owner June 27, 2023 21:25
@FrozenPandaz FrozenPandaz requested a review from vsavkin June 27, 2023 21:25
@vercel
Copy link

vercel bot commented Jun 27, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 27, 2023 9:30pm

@nx-cloud
Copy link

nx-cloud bot commented Jun 27, 2023 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 64b2153. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@FrozenPandaz FrozenPandaz merged commit c0508e3 into nrwl:master Jun 28, 2023
FrozenPandaz added a commit that referenced this pull request Jun 28, 2023
@FrozenPandaz
fix(core): fix workspace validation for implicitDependencies that are… (
09f8a8d 
#17825)

(cherry picked from commit c0508e3)
@timonmasberg timonmasberg mentioned this pull request Jun 30, 2023
Closed
@github-actions github-actions bot mentioned this pull request Jun 30, 2023
Closed
@github-actions
Copy link

github-actions bot commented Jul 4, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AgentEnder AgentEnder AgentEnder approved these changes

@vsavkin vsavkin Awaiting requested review from vsavkin vsavkin is a code owner automatically assigned from nrwl/nx-core-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

> NX desiredImplicitDeps.filter is not a function
2 participants
@FrozenPandaz @AgentEnder