fix(core): improve error message when native binaries are not found for a supported platform #17817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Cammisuli
force-pushed
the
improve_non_supported_message
branch
from
42640c5 to
dc29ee7
Compare
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 8b64819. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
AgentEnder
approved these changes
Jun 27, 2023
AgentEnder
reviewed
Jun 27, 2023
AgentEnder
reviewed
Jun 27, 2023
Cammisuli
force-pushed
the
improve_non_supported_message
branch
from
121ed14 to
9b082e6
Compare
…or a supported platform
…rtedPlatform The comments that explained the purpose of the assertSupportedPlatform function were removed as they were deemed unnecessary. The function is self-explanatory and the comments were creating clutter. As part of the change, 'For more information...' line is also added to provide a troubleshooting link to users encountering installation issues.
Cammisuli
force-pushed
the
improve_non_supported_message
branch
from
9b082e6 to
33240fc
Compare
FrozenPandaz
requested changes
Jun 28, 2023
Comment on lines
31
to
37
| Be prepared to give as much detail as possible about your system, we will need the following information at a minimum: | ||
|
|
||
| - Operating system | ||
| - Operating system version | ||
| - CPU Architecture (x64, arm64, etc) | ||
| - Node version | ||
| - Package manager (npm, yarn, pnpm, etc), it's version and the install command |
There was a problem hiding this comment.
All of this is available in nx report right? We should tell them to include that rather than listing this out?
FrozenPandaz
approved these changes
Jun 29, 2023
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
When a platform is supported but native binaries are not found, the error message says that the platform is not supported. Even though it is.
Expected Behavior
A supported platform with missing dependencies will have a clearer message
Related Issue(s)
Related #17767