feat(storybook): move tsconfig one level up

[mandarini]

See this PR for context: #17745

This solves the vite paths issue.

vite-tsconfig-paths plugin will not run resolversByDir for the .storybook dir, but rather for the project's root. So it does not take into account the paths included in the .storybook/tsconfig.file. Then, it looks one level up to find resolvers.
The vite-tsconfig-paths is setting up the resolvers to match the tsconfig.json settings under the .storybook directory, and different ones for the tsconfig.*.json files it’s finding in the project root. Since we're excluding .stories.* files in the project's root tsconfig, then it's failing.

Now, if we move the .storybook/tsconfig.json file to be tsconfig.storybook.json file in the project's root, then the vite-tsconfig-paths plugin will be able to resolve the paths, then, since it will be at the root of the project.

Is it ok to remove tsconfig.json from the .storybook dir?

Yes, since only @storybook/angular is using .storybook/tsconfig.json, the other frameworks ignore it. And @storybook/angular resolves the paths correctly, so we'll keep it as is for Angular projects

Why do we need a tsconfig file for Storybook anyway?

Because we want to exclude .stories.* files from the ts compilation if we're building the actual project. And our builders import specifically the tsconfig.app|lib.json file. But of course, we want to include the .stories.* files for Storybook builder and server. So, we need this extra file to include the stories that the tsconfig.app|lib.json file exludes.

TODO (done ✅ ):

• Write migrations
• Test it locally

Tested the following:

1. React + Vite: app, lib, app that imports lib which imports lib, which imports lib. Story which imports lib which imports lib. Build + Build-Storybook
2. React + Webpack: app, lib, app that imports lib which imports lib, which imports lib. Story which imports lib which imports lib. Build + Build-Storybook
3. Angular: app, lib, all's unchanged
4. Tested migration

Related Issue(s)

Fixes #17257 #17156

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
nx-dev	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 26, 2023 0:49am

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 43cef5f. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 1 target

• nx affected -t e2e-macos --parallel=1 --base=b736992968eb57625c02f54fd5801ec19e78f505 --head=43cef5f0014afdbc203d3672e61c4f5508f2d97e

---

Sent with 💌 from NxCloud.

[mandarini]

Local testing works - like create workspace, add storybook, build and run storybook.

Needs more testing though. Do not merge yet

[github-actions]

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.