fix(core): determine workspace type when creating workspace passing "angular" or "react" as preset #17724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…angular" or "react" as preset
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit c0ec973. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
leosvelperez
requested review from
FrozenPandaz,
vsavkin,
AgentEnder,
jaysoo and
JamesHenry
as code owners
jaysoo
approved these changes
Jun 22, 2023
meeroslav
pushed a commit
to ericyd/nx
that referenced
this pull request
Jun 23, 2023
…angular" or "react" as preset (nrwl#17724)
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
When creating a new workspace, if
--preset=angularor--preset=reactis provided, an empty workspace is created with no application.Expected Behavior
When creating a new workspace, if
--preset=angularor--preset=reactis provided, the user should be prompted which workspace type (standalone or integrated) they want to create.Related Issue(s)
Fixes #17398