Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nest): allow es2021 as target for libs #17690

Closed
wants to merge 1 commit into from

Conversation

timonmasberg
Copy link

@timonmasberg timonmasberg commented Jun 20, 2023

Current Behavior

Currently, ES2021 is not a valid target for NestJS libraries. NestJS itself targets ES2021, since Node v12 support has been dropped, on every package.

Expected Behavior

ES2021 should be a valid target for libraries in the generator schema.

@timonmasberg timonmasberg requested a review from a team as a code owner June 20, 2023 13:21
@vercel
Copy link

vercel bot commented Jun 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 20, 2023 1:41pm

@gperdomor
Copy link
Contributor

@timonmasberg I was working on the same without knowing about this MR... In my case I setup es2021 as default target in app and lib generators... Maybe can we close this MR in favor of #17726... WDYT?

@gperdomor
Copy link
Contributor

@timonmasberg I was working on the same without knowing about this MR... In my case I also setup es2021 as default target in generators... Maybe can we close this MR in favor of #17726

@timonmasberg
Copy link
Author

@timonmasberg I was working on the same without knowing about this MR... In my case I also setup es2021 as default target in generators... Maybe can we close this MR in favor of #17726

sure, having the default on es2021 is probably smart, since it aligns with the NestJS schematics

@timonmasberg timonmasberg deleted the patch-2 branch June 22, 2023 15:18
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants