-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(nest): allow es2021 as target for libs #17690
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@timonmasberg I was working on the same without knowing about this MR... In my case I setup es2021 as default target in app and lib generators... Maybe can we close this MR in favor of #17726... WDYT? |
@timonmasberg I was working on the same without knowing about this MR... In my case I also setup es2021 as default target in generators... Maybe can we close this MR in favor of #17726 |
sure, having the default on es2021 is probably smart, since it aligns with the NestJS schematics |
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Current Behavior
Currently,
ES2021
is not a valid target for NestJS libraries. NestJS itself targets ES2021, since Node v12 support has been dropped, on every package.Expected Behavior
ES2021
should be a valid target for libraries in the generator schema.