Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(nest): add migrations to nest 10 #17681 #17685

Merged
merged 1 commit into from
Jun 21, 2023
Merged

feat(nest): add migrations to nest 10 #17681 #17685

merged 1 commit into from
Jun 21, 2023

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented Jun 20, 2023 •
edited by leosvelperez
Loading

Current Behavior

We don't currently generate nest projects with version 10

Expected Behavior

Generate nest with version 10
Add migrations to upgrade Nx workspaces on nest 9 to 10

Related Issue(s)

Fixes #17681
Fixes #17400

@Coly010 Coly010 self-assigned this Jun 20, 2023
@vercel
Copy link

vercel bot commented Jun 20, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 20, 2023 2:08pm

@nx-cloud
Copy link

nx-cloud bot commented Jun 20, 2023 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 3000f62. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 8 targets

Sent with 💌 from NxCloud.

@Coly010 Coly010 force-pushed the nest/support-v10 branch from 02d332a to 01d80e2 Compare June 20, 2023 09:41
@Coly010 Coly010 marked this pull request as ready for review June 20, 2023 09:41
@Coly010 Coly010 requested a review from a team as a code owner June 20, 2023 09:41
@Coly010 Coly010 requested a review from jaysoo June 20, 2023 09:41
FrozenPandaz
FrozenPandaz requested changes Jun 20, 2023
View reviewed changes
packages/nest/migrations.json Outdated Show resolved Hide resolved
@Coly010 Coly010 force-pushed the nest/support-v10 branch from 01d80e2 to 3000f62 Compare June 20, 2023 14:05
@Coly010 Coly010 requested a review from FrozenPandaz June 20, 2023 14:05
@Coly010 Coly010 merged commit f35a4ac into nrwl:master Jun 21, 2023
@Coly010 Coly010 deleted the nest/support-v10 branch June 21, 2023 17:33
meeroslav pushed a commit to ericyd/nx that referenced this pull request Jun 23, 2023
@Coly010 @meeroslav
feat(nest): add migrations to nest 10 nrwl#17681 (nrwl#17685)
3f205a9
@timonmasberg timonmasberg mentioned this pull request Jun 24, 2023
Merged
@github-actions github-actions bot mentioned this pull request Jun 24, 2023
Closed
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@FrozenPandaz FrozenPandaz FrozenPandaz approved these changes

@jaysoo jaysoo jaysoo approved these changes

Assignees

@Coly010 Coly010

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NestJS 10 support NX migrate latest (16.3.2) migrates NestJs to incompatible version with Angular
3 participants
@Coly010 @jaysoo @FrozenPandaz