Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nextjs): cleanup old options for server executor (proxyConfig) #17626

Merged
merged 1 commit into from
Jun 16, 2023

Conversation

ndcunningham
Copy link
Contributor

The implementation for proxyConfig was already removed since we are now using Next.js' CLI.

This is just cleaning up and removing the deprecation message,

@ndcunningham ndcunningham requested review from a team as code owners June 15, 2023 20:14
@ndcunningham ndcunningham self-assigned this Jun 15, 2023
@ndcunningham ndcunningham requested review from jaysoo and bcabanes June 15, 2023 20:14
@vercel
Copy link

vercel bot commented Jun 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 16, 2023 2:54pm

@jaysoo
Copy link
Member

jaysoo commented Jun 16, 2023

LGTM!

@jaysoo jaysoo merged commit bfe8e47 into nrwl:master Jun 16, 2023
@ndcunningham ndcunningham deleted the fix/nextjs-clean-up-proxy branch June 16, 2023 16:35
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants