Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(react): bump emotion packages versions #17614

Merged

Conversation

leosvelperez
Copy link
Member

@leosvelperez leosvelperez commented Jun 15, 2023

Current Behavior

The installed @emotion/react package version doesn't play well with Typescript 5.1 and React 18. We'll add support for Typescript 5.1 as part of the Angular 16.1 support (#17155) and this surfaces the issue as can be seen in a failing e2e test https://staging.nx.app/runs/aoiNX1MRz5/task/e2e-next%3Ae2e.

This issue was addressed in @emotion/[email protected].

Note: I created this in a separate PR to keep it more granular and reduce the size of the Angular 16.1 PR.

Expected Behavior

The installed @emotion/react package version supports TS 5.1.

Related Issue(s)

Fixes #

@leosvelperez leosvelperez self-assigned this Jun 15, 2023
@vercel
Copy link

vercel bot commented Jun 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 15, 2023 10:33am

@leosvelperez leosvelperez marked this pull request as ready for review June 15, 2023 11:08
@leosvelperez leosvelperez requested a review from a team as a code owner June 15, 2023 11:08
@leosvelperez leosvelperez merged commit 5075138 into nrwl:master Jun 15, 2023
@leosvelperez leosvelperez deleted the react/bump-emotion-pkgs-versions branch June 15, 2023 15:42
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants