Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nextjs): Update package.json build scripts #17424

Merged

Conversation

ndcunningham
Copy link
Contributor

When nextjs project is built for production inside package.json we will update scripts

Before

  "scripts": {
    "start": "nx serve",
    "build": "nx build",
    "test": "nx test"
  },

After

  "scripts": {
    "start": "next start"
  },

closes: #17260

@ndcunningham ndcunningham requested a review from a team as a code owner June 5, 2023 15:20
@ndcunningham ndcunningham requested a review from mandarini June 5, 2023 15:20
@vercel
Copy link

vercel bot commented Jun 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 5, 2023 3:25pm

@ndcunningham ndcunningham merged commit 1b7cb39 into nrwl:master Jun 5, 2023
@ndcunningham ndcunningham deleted the fix/nextjs-packagejson-build-scripts branch June 5, 2023 16:01
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Next app fails to start in production mode
2 participants