Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nextjs): adjust generated CSS-in-JS to match latest Next.js recommendations #17294

Merged
merged 1 commit into from
May 30, 2023

Conversation

jaysoo
Copy link
Member

@jaysoo jaysoo commented May 29, 2023

Next.js has compiler options for styled-components and emotion now, so we should generated next.config.js with the latest config. For App Router, the styled-components and styled-jsx usage should also provide custom layout.tsx that uses a registry specific to each styling solution. Emotion support in layout.tsx is pending, but for now users will at least have the compiler: { emotion: true } value added to their next.config.js file.

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@jaysoo jaysoo requested a review from a team as a code owner May 29, 2023 18:52
@jaysoo jaysoo requested a review from ndcunningham May 29, 2023 18:52
@vercel
Copy link

vercel bot commented May 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 29, 2023 8:57pm

@jaysoo jaysoo merged commit a7c6d5a into nrwl:master May 30, 2023
@jaysoo jaysoo deleted the fix/nextjs-css-in-js branch May 30, 2023 16:12
@github-actions
Copy link

github-actions bot commented Jun 5, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants