[Do not merge]: feat(bundling): Add support to rollup for babelUpwardRootMode

[ndcunningham]

No description provided.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
nx-dev	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 31, 2023 11:45pm

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit a01a03f. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 8 targets

• nx affected -t e2e-macos --parallel=1 --base=51ff8627d4d9e1e660c165e7b97f56b9e7400047 --head=a01a03f10df4776aa4d0451e5be6bd0a0a854f73
• nx affected --target=e2e --base=51ff8627d4d9e1e660c165e7b97f56b9e7400047 --head=a01a03f10df4776aa4d0451e5be6bd0a0a854f73 --parallel=1
• nx affected --target=build --base=51ff8627d4d9e1e660c165e7b97f56b9e7400047 --head=a01a03f10df4776aa4d0451e5be6bd0a0a854f73 --parallel=3
• nx affected --target=test --base=51ff8627d4d9e1e660c165e7b97f56b9e7400047 --head=a01a03f10df4776aa4d0451e5be6bd0a0a854f73 --parallel=1
• nx run-many -t check-imports check-commit check-lock-files depcheck check-codeowners documentation --parallel=1 --no-dte
• nx affected --target=lint --base=51ff8627d4d9e1e660c165e7b97f56b9e7400047 --head=a01a03f10df4776aa4d0451e5be6bd0a0a854f73 --parallel=3
• nx-cloud record -- nx format:check --base=51ff8627d4d9e1e660c165e7b97f56b9e7400047 --head=a01a03f10df4776aa4d0451e5be6bd0a0a854f73
• nx documentation --no-dte

---

Sent with 💌 from NxCloud.

[jaysoo]

There seems to be missing logic to set rootMode: undefined | 'upward' in rollup.impl.ts. The new babelUpwardRootMode for @nx/rollup:rollup executor will allow users to set rootMode: 'upward' (matching previous behavior), otherwise we should set rootMode: undefined to only use the .babelrc of the current project being built.

I don't think we need to add the babelConfig option to generators. The .babelrc file is already added for the user depending on the --compiler option when generating a library, we just need to update the executor to not set rootMode: 'upward' by default.

[github-actions]

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.