feat(js): do not generate root babel.config.json for babel projects #17289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jaysoo
force-pushed
the
feat/do-not-use-babel-by-default
branch
from
c23ca90 to
04135ff
Compare
jaysoo
commented
May 29, 2023
jaysoo
commented
May 29, 2023
| @@ -71,36 +71,6 @@ export async function libraryGenerator(host: Tree, rawOptions: Schema) { | |||
| ); | |||
| addTsConfigPath(host, `${options.importPath}/server`, [serverEntryPath]); | |||
|
|
|||
| updateJson( | |||
There was a problem hiding this comment.
This never worked well, and the user should already have emotion and styled-components in the app. As per this PR (#17286) the app's babel config will now be applied to the libs as well. You never want to be in a situation where different styling solutions are used between apps and libs without a build step in the lib to normalize to CSS or something.
There was a problem hiding this comment.
We'll need a follow-up PR to enable emotion and styled-components in SWC for Next.js since they've added some early support for them.
jaysoo
force-pushed
the
feat/do-not-use-babel-by-default
branch
from
04135ff to
9ee6a36
Compare
jaysoo
commented
May 29, 2023
| if (host.exists(joinPathFragments(options.projectRoot, '.babelrc'))) { | ||
| host.delete(joinPathFragments(options.projectRoot, '.babelrc')); | ||
| } | ||
| if (options.compiler === 'babel') { |
There was a problem hiding this comment.
Inlined the .babelrc creation here rather than in the files folder.
jaysoo
force-pushed
the
feat/do-not-use-babel-by-default
branch
2 times, most recently
from
0879035 to
dd012fc
Compare
jaysoo
force-pushed
the
feat/do-not-use-babel-by-default
branch
from
dd012fc to
e436e39
Compare
jaysoo
force-pushed
the
feat/do-not-use-babel-by-default
branch
from
e436e39 to
bfaadf5
Compare
jaysoo
requested review from
AgentEnder,
isaacplmann and
ndcunningham
and removed request for
AgentEnder
jaysoo
force-pushed
the
feat/do-not-use-babel-by-default
branch
from
bfaadf5 to
6d2265e
Compare
jaysoo
force-pushed
the
feat/do-not-use-babel-by-default
branch
from
6d2265e to
5db0408
Compare
jaysoo
force-pushed
the
feat/do-not-use-babel-by-default
branch
from
99466fe to
e776a20
Compare
barbados-clemens
approved these changes
May 30, 2023
jaysoo
force-pushed
the
feat/do-not-use-babel-by-default
branch
from
e776a20 to
ba5ad48
Compare
jaysoo
force-pushed
the
feat/do-not-use-babel-by-default
branch
from
ba5ad48 to
75f4ac9
Compare
jaysoo
changed the title
ndcunningham
reviewed
Jun 5, 2023
| @@ -138,7 +138,7 @@ | |||
| "type": "string", | |||
| "description": "The compiler to use", | |||
| "enum": ["babel", "swc"], | |||
| "default": "babel" | |||
| "default": "swc" | |||
There was a problem hiding this comment.
should this be babel as well?
| @@ -143,7 +143,7 @@ | |||
| "type": "string", | |||
| "description": "The compiler to use.", | |||
| "enum": ["babel", "swc"], | |||
| "default": "babel" | |||
| "default": "swc" | |||
jaysoo
force-pushed
the
feat/do-not-use-babel-by-default
branch
from
75f4ac9 to
6f55dfc
Compare
jaysoo
force-pushed
the
feat/do-not-use-babel-by-default
branch
from
6f55dfc to
ca7af0b
Compare
jaysoo
force-pushed
the
feat/do-not-use-babel-by-default
branch
from
ee2f0e2 to
8d180e3
Compare
jaysoo
force-pushed
the
feat/do-not-use-babel-by-default
branch
from
8d180e3 to
755719a
Compare
jaysoo
force-pushed
the
feat/do-not-use-babel-by-default
branch
from
755719a to
a09425d
Compare
- Project will only use its .babelrc and ignore .babelrc of other projects (e.g. other libs) - For prevous behavior user can set `babelUpwardRootMode: true` for @nx/webpack:webpack or @nx/rollup:rollup executors
jaysoo
force-pushed
the
feat/do-not-use-babel-by-default
branch
from
a09425d to
b0a7cf5
Compare
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that
babel.config.jsonis not generated in new projects. The default behavior is to only apply.babelrcfile for individual projects and ignore its dependencies'.babelrcfiles. The implication of not usingrootMode: upwardis that any babel presets/plugins needed by a a dependency also needs to be added to the dependent project's.babelrcfile.Additionally, anywhere that we can safely swap to SWC instead of Babel we will do so by default.
Notes
@nx/nodeand@nx/expressdo not support building projects using Babel, so thebabelJestoption is deprecated andswcJestis added to generate Jest project with@swc/jest(to speed up test compile).