fix(nest): require typescript lazily in library generator #17281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit adf598a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
leosvelperez
force-pushed
the
node/fix-eager-ts-require
branch
from
6b73a47 to
0a88a5e
Compare
FrozenPandaz
approved these changes
May 30, 2023
auto-merge was automatically disabled
May 31, 2023 07:31
Pull request was closed
leosvelperez
force-pushed
the
node/fix-eager-ts-require
branch
from
0a88a5e to
adf598a
Compare
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Creating a new workspace with NestJS throws due to the library generator eagerly requiring
typescript, which is not available at that point in time of the execution.Expected Behavior
Creating a new workspace with NestJS succeeds.
Related Issue(s)
Fixes #17279