-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(nextjs): remove the "root" option from Next.js build executor since it can be inferred #17248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ndcunningham
approved these changes
May 26, 2023
packages/next/src/migrations/update-16-3-0/remove-root-build-option.spec.ts
Show resolved
Hide resolved
jaysoo
force-pushed
the
feat/nextjs-simplify-options
branch
from
May 26, 2023 16:13
5facce3
to
45e7278
Compare
jaysoo
force-pushed
the
feat/nextjs-simplify-options
branch
from
May 26, 2023 18:01
45e7278
to
20c1a7b
Compare
jaysoo
force-pushed
the
feat/nextjs-simplify-options
branch
from
May 26, 2023 18:21
20c1a7b
to
56fd2b2
Compare
jaysoo
force-pushed
the
feat/nextjs-simplify-options
branch
from
May 26, 2023 18:26
56fd2b2
to
81b779d
Compare
…nce it can be inferred
jaysoo
force-pushed
the
feat/nextjs-simplify-options
branch
from
May 26, 2023 18:30
81b779d
to
85cf4a4
Compare
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We never needed the
root
option for@nx/next:build
executor since we know the project root by reading the graph. This PR:root
option from said executor.Current Behavior
Expected Behavior
Related Issue(s)
Fixes #