Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nextjs): remove the "root" option from Next.js build executor since it can be inferred #17248

Merged
merged 1 commit into from
May 26, 2023

Conversation

jaysoo
Copy link
Member

@jaysoo jaysoo commented May 26, 2023

We never needed the root option for @nx/next:build executor since we know the project root by reading the graph. This PR:

  1. Removes the root option from said executor.
  2. Update app generator to no longer generate with it.
  3. Adds a migration to remove it from existing projects.

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@jaysoo jaysoo marked this pull request as ready for review May 26, 2023 15:36
@jaysoo jaysoo requested a review from a team as a code owner May 26, 2023 15:36
@jaysoo jaysoo requested a review from ndcunningham May 26, 2023 15:36
@vercel
Copy link

vercel bot commented May 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 26, 2023 6:33pm

@jaysoo jaysoo force-pushed the feat/nextjs-simplify-options branch from 81b779d to 85cf4a4 Compare May 26, 2023 18:30
@jaysoo jaysoo enabled auto-merge (squash) May 26, 2023 19:02
@jaysoo jaysoo merged commit 9881efa into nrwl:master May 26, 2023
@jaysoo jaysoo deleted the feat/nextjs-simplify-options branch May 26, 2023 19:30
@github-actions
Copy link

github-actions bot commented Jun 1, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants