Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(webpack): support webworker (#17136) #17137

Merged
merged 1 commit into from
May 31, 2023
Merged

fix(webpack): support webworker (#17136) #17137

merged 1 commit into from
May 31, 2023

Conversation

MaximSagan
Copy link
Contributor

Current Behavior

Webpack cannot target webworker

Expected Behavior

Webpack can target webworker

Fixes #17136

@vercel
Copy link

vercel bot commented May 22, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 31, 2023 1:22pm

@nx-cloud
Copy link

nx-cloud bot commented May 22, 2023 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit f0d2258. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 8 targets

Sent with 💌 from NxCloud.

mandarini
mandarini approved these changes May 23, 2023
View reviewed changes
Copy link
Member

@mandarini mandarini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@mandarini mandarini enabled auto-merge (squash) May 23, 2023 07:52
@jaysoo jaysoo force-pushed the feature/webpack-allow-webworker branch from c86995f to f0d2258 Compare May 31, 2023 13:19
@jaysoo jaysoo requested review from a team as code owners May 31, 2023 13:19
@jaysoo jaysoo requested a review from bcabanes May 31, 2023 13:19
@mandarini mandarini merged commit 8251906 into nrwl:master May 31, 2023
@timonmasberg timonmasberg mentioned this pull request Jun 1, 2023
Closed
@github-actions github-actions bot mentioned this pull request Jun 1, 2023
Closed
@github-actions
Copy link

github-actions bot commented Jun 6, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mandarini mandarini mandarini approved these changes

@jaysoo jaysoo jaysoo approved these changes

@ndcunningham ndcunningham Awaiting requested review from ndcunningham

@bcabanes bcabanes Awaiting requested review from bcabanes bcabanes is a code owner automatically assigned from nrwl/nx-docs-reviewers

Assignees

@jaysoo jaysoo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Webpack cannot target webworker
3 participants
@MaximSagan @jaysoo @mandarini