-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(testing): skip nextjs ct/e2e test #17087
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
barbados-clemens
force-pushed
the
cy-e2e-issue
branch
from
May 18, 2023 16:33
2eaf486
to
aa7806c
Compare
barbados-clemens
force-pushed
the
cy-e2e-issue
branch
from
May 18, 2023 19:35
aa7806c
to
a1dfbe2
Compare
barbados-clemens
added
the
scope: testing tools
Issues related to Cypress / Jest / Playwright / Vitest support in Nx
label
May 18, 2023
barbados-clemens
changed the title
chore(testing): wip
chore(testing): skip nextjs ct/e2e test
May 18, 2023
barbados-clemens
force-pushed
the
cy-e2e-issue
branch
from
May 18, 2023 19:38
a1dfbe2
to
e9b76e5
Compare
barbados-clemens
requested review from
jaysoo,
ndcunningham,
vsavkin and
AgentEnder
May 18, 2023 19:38
barbados-clemens
force-pushed
the
cy-e2e-issue
branch
from
May 18, 2023 19:46
e9b76e5
to
206ca18
Compare
barbados-clemens
force-pushed
the
cy-e2e-issue
branch
from
May 18, 2023 20:02
206ca18
to
4a592fd
Compare
AgentEnder
approved these changes
May 18, 2023
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
cypress e2e is failing bc of nextjs port isn't being closed when using
runExecutor
in the cypress tests, but only in CI, causing master to be red. commenting out until we can figure out what is exactly happening.Expected Behavior
Related Issue(s)
Fixes #