Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(testing): skip nextjs ct/e2e test #17087

Merged
merged 1 commit into from
May 18, 2023

Conversation

barbados-clemens
Copy link
Contributor

@barbados-clemens barbados-clemens commented May 18, 2023

Current Behavior

cypress e2e is failing bc of nextjs port isn't being closed when using runExecutor in the cypress tests, but only in CI, causing master to be red. commenting out until we can figure out what is exactly happening.

Expected Behavior

Related Issue(s)

Fixes #

@vercel
Copy link

vercel bot commented May 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview May 18, 2023 8:03pm

@barbados-clemens barbados-clemens self-assigned this May 18, 2023
@barbados-clemens barbados-clemens added the scope: testing tools Issues related to Cypress / Jest / Playwright / Vitest support in Nx label May 18, 2023
@barbados-clemens barbados-clemens changed the title chore(testing): wip chore(testing): skip nextjs ct/e2e test May 18, 2023
@barbados-clemens barbados-clemens marked this pull request as ready for review May 18, 2023 20:20
@AgentEnder AgentEnder merged commit 7ab303f into nrwl:master May 18, 2023
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
scope: testing tools Issues related to Cypress / Jest / Playwright / Vitest support in Nx
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants