Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(js): use valid file paths on Windows when executing program #16911

Merged
merged 1 commit into from
May 10, 2023

Conversation

jaysoo
Copy link
Member

@jaysoo jaysoo commented May 10, 2023

Absolute paths on Windows are not valid file paths when using dynamic import(...) calls. Need to use pathToFileURL first before importing.

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #16834

@jaysoo jaysoo requested review from nartc and ndcunningham as code owners May 10, 2023 12:49
@vercel
Copy link

vercel bot commented May 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 10, 2023 0:55am

@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Only URLs with a scheme in: file and data are supported by the default ESM loader.
2 participants