fix(misc): ensure workspace directory is normalized correctly

[leosvelperez]

Current Behavior

When creating a new workspace a providing a repo name with _ in it, an error is thrown due to a mismatch in the directory name used by the new generator vs the create-nx-workspace functionality. This mainly happens because the new generator is invoked with the non-normalized name and this generator wrongly sets the directory to that value instead of setting it with the normalized name.

Expected Behavior

Creating a new workspace providing a repo name with _ should not throw an error.

Related Issue(s)

Fixes #16841

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
nx-dev	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 8, 2023 10:25am

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 8712d23. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 8 targets

• nx affected -t e2e-macos --parallel=1 --base= --head=
• nx affected --target=e2e --base=065477610605d5799babc3ba78f26cdfe8737250 --head=8712d230471cbe3b2ca37f6375b2e924253be4d3 --parallel=1
• nx affected --target=test --base=065477610605d5799babc3ba78f26cdfe8737250 --head=8712d230471cbe3b2ca37f6375b2e924253be4d3 --parallel=1
• nx affected --target=build --base=065477610605d5799babc3ba78f26cdfe8737250 --head=8712d230471cbe3b2ca37f6375b2e924253be4d3 --parallel=3
• nx run-many -t check-imports check-commit check-lock-files depcheck check-codeowners --parallel=1 --no-dte
• nx affected --target=lint --base=065477610605d5799babc3ba78f26cdfe8737250 --head=8712d230471cbe3b2ca37f6375b2e924253be4d3 --parallel=3
• nx-cloud record -- nx format:check --base=065477610605d5799babc3ba78f26cdfe8737250 --head=8712d230471cbe3b2ca37f6375b2e924253be4d3
• nx documentation --no-dte

---

Sent with 💌 from NxCloud.

[leosvelperez]

The ${directory} here was useless. The name arg takes precedence over the positional arg and overwrites it.

I'm normalizing the name option above, which is a known and required option, so we don't rely on the new generator rederiving it. We could also pass the directory option directly so it's more deterministic and we don't rely on some behavior in the new generator, but that option is not in the new generator schema for some reason. If someone can confirm whether it's intentional or just something we missed, I can add it and pass the option directly.

[github-actions]

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.