Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): handle ngrx imports for apps that do not migrate to config file #16812

Merged
merged 1 commit into from
May 9, 2023

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented May 5, 2023

Current Behavior

We assume everyone migrates to the app.config.ts file for the ngrx to function correctly when using standalone apis

Expected Behavior

some users may skip this migration, therefore we should still handle bootstrapApplication

Related Issue(s)

Fixes #

@Coly010 Coly010 requested a review from leosvelperez as a code owner May 5, 2023 12:59
@Coly010 Coly010 self-assigned this May 5, 2023
@vercel
Copy link

vercel bot commented May 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) May 5, 2023 1:00pm

@Coly010 Coly010 merged commit 6728bbb into nrwl:master May 9, 2023
@Coly010 Coly010 deleted the angular/fix-ngrx-imports branch May 9, 2023 08:31
FrozenPandaz pushed a commit that referenced this pull request May 9, 2023
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants