Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(misc): avoid writing unformatted json if prettier is available #16775

Conversation

AgentEnder
Copy link
Member

@AgentEnder AgentEnder commented May 4, 2023

Current Behavior

We write JSON files without any kind of formatting in several places (e.g. migrate, nx init, graph --file).

Expected Behavior

If prettier is available, its used to format the file.

Related Issue(s)

Fixes #8928

@vercel
Copy link

vercel bot commented May 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 5, 2023 5:29pm

@AgentEnder AgentEnder force-pushed the fix/format-json-files-with-prettier-when-writing branch from 9a1295b to 8102a7f Compare May 4, 2023 17:19
@AgentEnder AgentEnder force-pushed the fix/format-json-files-with-prettier-when-writing branch from 8102a7f to 7743a84 Compare May 4, 2023 17:24
@AgentEnder AgentEnder force-pushed the fix/format-json-files-with-prettier-when-writing branch from 7743a84 to 6952570 Compare May 4, 2023 20:09
@AgentEnder AgentEnder marked this pull request as draft May 4, 2023 21:00
@AgentEnder AgentEnder force-pushed the fix/format-json-files-with-prettier-when-writing branch from 6952570 to 87f3c77 Compare May 4, 2023 21:53
Copy link

github-actions bot commented Jun 7, 2024

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nx migrate doesn't respect configured indent_size
1 participant