fix(nextjs): add workspace dependencies to transpilePackages automatically #16774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jaysoo
changed the title
jaysoo
commented
May 4, 2023
| @@ -204,6 +207,22 @@ function withNx( | |||
| dependencies = result.dependencies; | |||
| } | |||
|
|
|||
| // For Next.js 13.1 and greater, make sure workspace libs are transpiled. | |||
| forNextVersion('>=13.1.0', () => { | |||
There was a problem hiding this comment.
Added a util function that will us to support different configuration that are introduced in different Next.js versions.
jaysoo
commented
May 4, 2023
| updatePaths(dependencies, paths); | ||
| return paths; | ||
| } | ||
|
|
||
| function readPaths(tsConfig: string | ts.ParsedCommandLine) { |
There was a problem hiding this comment.
Moved this to ts utils since it's not specific to buildable libs.
jaysoo
force-pushed
the
fix/issue-16658
branch
2 times, most recently
from
3567286 to
198278c
Compare
ndcunningham
approved these changes
May 4, 2023
nartc
approved these changes
May 4, 2023
4 tasks
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are issues with Next.js not transpiling workspace libraries (i.e. packages with aliases in tsconfig). You can see this problem even without Nx, where you have to manually specify
transpilePackagesif you use aliases.See: https://github.com/jaysoo/next-with-libs/tree/no-nx
This PR adds a feature where we will automatically add those packages for the user since we know they need to be specified anyway.
Note: This only applies if the user is not using the apps/libs setup.
Current Behavior
Expected Behavior
Related Issue(s)
Fixes #16658