fix(core): improve touched projects locator performance #16682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
FrozenPandaz
commented
May 1, 2023
| const isProjectFile = minimatch(touchedFile.file, combinedGlobPattern); | ||
| if (isProjectFile) { | ||
| // If the file no longer exists on disk, then it was deleted | ||
| if (!existsSync(join(workspaceRoot, touchedFile.file))) { |
There was a problem hiding this comment.
This is the new line
AgentEnder
approved these changes
May 1, 2023
FrozenPandaz
added a commit
that referenced
this pull request
May 1, 2023
(cherry picked from commit 96fca45)
FrozenPandaz
added a commit
that referenced
this pull request
May 4, 2023
(cherry picked from commit 96fca45)
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Detecting if a project was deleted requires running a git command to get the contents of a .json file which takes a long time.
Expected Behavior
Detecting if a project was deleted is as simple as checking if the config file is still present on disk.
This brings the time needed to filter affected projects for 22 changed project configs from:
These numbers are from the nx repo on my machine.
Related Issue(s)
Fixes #