-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(misc): list should link to nx.dev/community for more plugins #16673
feat(misc): list should link to nx.dev/community for more plugins #16673
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
packages/nx/src/command-line/list.ts
Outdated
title: | ||
'Nx has a fantastic community that is continuously adding new plugins, tools, and capabilities.', | ||
bodyLines: [`Find more great plugins at https://nx.dev/community.`], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that could be better. My only hang up is a silly one - I don't really like the way the line lengths increase over the 3 lines. Not got a better solution though, and I like the messaging.
Since its just a bit of bike shedding maybe we could open it up to some more internal people to propose messaging?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would probably look better if you moved the link to the end of the last line. I don't think we should dwell on it too much.
Search for the one you need here: https://nx.dev/community#plugin-directory
182a274
to
5f05f5a
Compare
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Current Behavior
We list all community plugins in the
nx list
command directly. This list is getting really long which is a good thing, but as such is no longer suitable to display in its entiretyExpected Behavior
To avoid bias, we can't really display a subsection of the community list in its current form. We don't collect data such as github stars, npm downloads or similar currently, and that would be a bit of a rabbit hole anyways.
Instead, we display a message and link to nx.dev/community:
Related Issue(s)
Fixes #