Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(misc): list should link to nx.dev/community for more plugins #16673

Merged
merged 1 commit into from
May 2, 2023

Conversation

AgentEnder
Copy link
Member

Current Behavior

We list all community plugins in the nx list command directly. This list is getting really long which is a good thing, but as such is no longer suitable to display in its entirety

Expected Behavior

To avoid bias, we can't really display a subsection of the community list in its current form. We don't collect data such as github stars, npm downloads or similar currently, and that would be a bit of a rabbit hole anyways.

Instead, we display a message and link to nx.dev/community:
image

Related Issue(s)

Fixes #

@vercel
Copy link

vercel bot commented May 1, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 2, 2023 2:57pm

Comment on lines 53 to 55
title:
'Nx has a fantastic community that is continuously adding new plugins, tools, and capabilities.',
bodyLines: [`Find more great plugins at https://nx.dev/community.`],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, we do have a fantastic community... but let's say something more like...

What do you think of this?

image

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that could be better. My only hang up is a silly one - I don't really like the way the line lengths increase over the 3 lines. Not got a better solution though, and I like the messaging.

Since its just a bit of bike shedding maybe we could open it up to some more internal people to propose messaging?

Copy link
Collaborator

@FrozenPandaz FrozenPandaz May 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would probably look better if you moved the link to the end of the last line. I don't think we should dwell on it too much.

Search for the one you need here: https://nx.dev/community#plugin-directory

@github-actions
Copy link

github-actions bot commented May 8, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants