fix(devkit): ensurePackage should obey npmrc and yarnrc.yml #16652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
AgentEnder
force-pushed
the
fix/copy-other-package-manager-config-files
branch
from
d25f13a to
f6a5a5f
Compare
FrozenPandaz
requested changes
May 1, 2023
| const f = findFileInPackageJsonDirectory(packageManagerConfigFile, root); | ||
| if (f) { | ||
| // Copy config file if it exists, so that the package manager still follows it. | ||
| copyFileSync(f, `${destination}/.npmrc`); |
There was a problem hiding this comment.
Change this to be the file found
| import { Tree } from 'nx/src/generators/tree'; | ||
| import { createTreeWithEmptyWorkspace } from 'nx/src/generators/testing-utils/create-tree-with-empty-workspace'; | ||
| import { | ||
| import type { Tree } from 'nx/src/generators/tree'; |
There was a problem hiding this comment.
Remove all changes to spec files
| @@ -39,7 +15,29 @@ | |||
| { | |||
| "files": ["*.ts", "*.tsx"], | |||
| "rules": { | |||
| "@typescript-eslint/explicit-module-boundary-types": ["error"] | |||
| "@typescript-eslint/explicit-module-boundary-types": ["error"], | |||
| "@typescript-eslint/no-restricted-imports": [ | |||
There was a problem hiding this comment.
Move these up to the previous .ts block
AgentEnder
force-pushed
the
fix/copy-other-package-manager-config-files
branch
from
4fbcd8b to
b619127
Compare
AgentEnder
force-pushed
the
fix/copy-other-package-manager-config-files
branch
from
b619127 to
01f530b
Compare
FrozenPandaz
approved these changes
May 1, 2023
FrozenPandaz
pushed a commit
that referenced
this pull request
May 1, 2023
(cherry picked from commit 2381dd3)
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
ensurePackagedoes not know how to obey.npmrc,.yarnrc, or.yarnrc.ymlnx migrateonly obeys.npmrcExpected Behavior
All package manager config files are obeyed
Related Issue(s)
Fixes #16644